(MODULES-8098) - Add logconfig option to config file #491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Readme change too ? |
|
dumb question, are the docs in the reference coming from puppet strings ? |
|
Yep! That burst entry that was added must just be due to Puppet Strings not being ran since it was added. |
|
Brillo !!! @eimlav |
raphink
reviewed
Jun 27, 2019
| @@ -90,7 +90,7 @@ | |||
|
|
|||
| if $ntp::disable_dhclient { | |||
| augeas { 'disable ntp-servers in dhclient.conf': | |||
| context => '/files/etc/dhcp/dhclient.conf', | |||
| context => '/etc/dhcp/dhclient.conf', | |||
There was a problem hiding this comment.
@eimlav Why was this changed? Maybe you meant to use incl instead of context? As it is, it seems to be currently broken.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.